kubeapi for matching pv/pvc to /dev/sd devices #4378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used in an upcoming PR to create DiskMetric objects for cluster PVCs. Signed-off-by: Andrew Durbin <[email protected]>
andrewd-zededa
force-pushed
the
kubeapi-diskmetric
branch
from
0e8ed65
to
3bf395b
Compare
rene
reviewed
Oct 25, 2024
| } | ||
|
|
||
| for _, devEnt := range blockDevs { | ||
| if !strings.HasPrefix(devEnt.Name(), "sd") { |
There was a problem hiding this comment.
@andrewd-zededa , why are you considering only sdX devices? What about devices that have NVMes that will be named into something like nvme0n1, nvme0n1p1, nvme0n1p2, nvme0n1p3?
There was a problem hiding this comment.
And also eMMCs, that in this case will be named as something like mmcblk0p1, mmcblk0p2, etc...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used in an upcoming PR to create DiskMetric objects for cluster PVCs.
When a cluster volume is created it will show on the controller as the PVC name. This PVC(PersistentVolumeClaim) has a linked PV(PersistentVolume) which is the name of a block device under /dev/longhorn/ which itself shares the same major:minor pair as one /dev/sdX device. Volumemgr will use this API to map from PVC->PV->/dev/sdX device to link from existing sdX DiskMetric object to a cluster volume DiskMetric if it is currently attached on this node.